drm/sti: Fix return type of sti_{dvo,hda,hdmi}_connector_mode_valid()
3Vexday Risk Score
No sign of exploitation. No public exploitation artifact known so far.
ssvc Trackepss 0.1%
exploitation probability
0.1%top 95% of all CVEs
observed exploitation
nono source reports it
In the Linux kernel, the following vulnerability has been resolved:
drm/sti: Fix return type of sti_{dvo,hda,hdmi}_connector_mode_valid()
With clang's kernel control flow integrity (kCFI, CONFIG_CFI_CLANG),
indirect call targets are validated against the expected function
pointer prototype to make sure the call target is valid to help mitigate
ROP attacks. If they are not identical, there is a failure at run time,
which manifests as either a kernel panic or thread getting killed. A
proposed warning in clang aims to catch these at compile time, which
reveals:
drivers/gpu/drm/sti/sti_hda.c:637:16: error: incompatible function pointer types initializing 'enum drm_mode_status (*)(struct drm_connector *, struct drm_display_mode *)' with an expression of type 'int (struct drm_connector *, struct drm_display_mode *)' [-Werror,-Wincompatible-function-pointer-types-strict]
.mode_valid = sti_hda_connector_mode_valid,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/sti/sti_dvo.c:376:16: error: incompatible function pointer types initializing 'enum drm_mode_status (*)(struct drm_connector *, struct drm_display_mode *)' with an expression of type 'int (struct drm_connector *, struct drm_display_mode *)' [-Werror,-Wincompatible-function-pointer-types-strict]
.mode_valid = sti_dvo_connector_mode_valid,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/sti/sti_hdmi.c:1035:16: error: incompatible function pointer types initializing 'enum drm_mode_status (*)(struct drm_connector *, struct drm_display_mode *)' with an expression of type 'int (struct drm_connector *, struct drm_display_mode *)' [-Werror,-Wincompatible-function-pointer-types-strict]
.mode_valid = sti_hdmi_connector_mode_valid,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
->mode_valid() in 'struct drm_connector_helper_funcs' expects a return
type of 'enum drm_mode_status', not 'int'. Adjust the return type of
sti_{dvo,hda,hdmi}_connector_mode_valid() to match the prototype's to
resolve the warning and CFI failure.
Affected products
Linux · LinuxReferences
https://git.kernel.org/stable/c/04371a75a58422a301a9ff9ae3babd310ac3bb3fhttps://git.kernel.org/stable/c/0ad811cc08a937d875cbad0149c1bab17f84ba05https://git.kernel.org/stable/c/511b48ee8e4aec2d03d2af06b363d9eb3230b017https://git.kernel.org/stable/c/6e3c4d3fa5d458d685561ecbaf8daa9dba14979ehttps://git.kernel.org/stable/c/8f9941dea3a70b73f2063f9dcc4aaae6af03c5bahttps://git.kernel.org/stable/c/a075c21ee026f4a74f9fce5928ea3c8d18a8af13https://git.kernel.org/stable/c/b2c92b2a3801b09b709cbefd9a9e4944b72400bfhttps://git.kernel.org/stable/c/b4307c7d35e346b909edfdc1f280902150570bb6https://git.kernel.org/stable/c/e578b0906b6a81479cd5b5b6c848a7096addf5e9